Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate assert to to ALPAKA_ASSERT_ACC [14.0.x] #44805

Merged
merged 5 commits into from
Apr 24, 2024
Merged

Migrate assert to to ALPAKA_ASSERT_ACC [14.0.x] #44805

merged 5 commits into from
Apr 24, 2024

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Apr 22, 2024

PR description:

Migrate assert() to ALPAKA_ASSERT_ACC().

PR validation:

None.

Backport of #44802 to 14.0.x for data taking.

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 22, 2024

backport #44802

@cmsbuild cmsbuild added this to the CMSSW_14_0_X milestone Apr 22, 2024
@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 22, 2024

+heterogeneous

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 22, 2024

enable gpu

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 22, 2024 •
edited
Loading

A new Pull Request was created by @fwyzard for CMSSW_14_0_X.

It involves the following packages:

  • CondFormats/SiPixelObjects (alca, db)
  • DataFormats/SiPixelClusterSoA (heterogeneous, reconstruction)
  • DataFormats/SiPixelDigiSoA (heterogeneous, reconstruction)
  • DataFormats/VertexSoA (heterogeneous, reconstruction)
  • HeterogeneousCore/AlpakaInterface (heterogeneous)
  • RecoLocalCalo/EcalRecProducers (reconstruction)
  • RecoLocalTracker/SiPixelRecHits (reconstruction)
  • RecoTracker/PixelSeeding (reconstruction)

@cmsbuild, @fwyzard, @makortel, @francescobrivio, @jfernan2, @perrotta, @mandrenguyen, @saumyaphor4252, @consuegs can you please review it and eventually sign? Thanks.
@tvami, @threus, @GiacomoSguazzoni, @makortel, @mtosi, @rovere, @argiro, @thomreis, @apsallid, @rsreds, @JanChyczynski, @JanFSchulte, @wang0jin, @tocheng, @missirol, @youyingli, @mmusich, @dkotlins, @mroguljic, @VinInn, @PonIlya, @tsusa, @seemasharmafnal, @VourMa, @felicepantaleo, @yuanchao, @dgulhan, @ferencek, @ReyerBand, @gpetruc, @rchatter this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 22, 2024 •
edited
Loading

cms-bot internal usage

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 22, 2024

please test

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 22, 2024

urgent

@cms-sw/orp-l2 please include this PR in the next CMSSW 14.0.x full release.
It is needed to support centrally enabling/disabling assertions in Alpaka GPU code, to evaluate the trade-off between improved error messages and faster HLT throughput.

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f81a9/39011/summary.html
COMMIT: 198c126
CMSSW: CMSSW_14_0_X_2024-04-22-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44805/39011/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f81a9/39011/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f81a9/39011/git-merge-result

RelVals

----- Begin Fatal Exception 23-Apr-2024 00:33:10 CEST-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_PAT_DQM.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoBTag/Combined/data/UParTAK4/PUPPI/V00/UParTAK4.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44805/39011/CMSSW_14_0_X_2024-04-22-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44805/39011/CMSSW_14_0_X_2024-04-22-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44805/39011/CMSSW_14_0_X_2024-04-22-1100/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/136.88811_RunJetHT2018DreMINIAODUL


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/src/FWCore/ParameterSet/python/Types.py(881): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/src/FWCore/ParameterSet/python/Mixins.py(381): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/src/FWCore/ParameterSet/python/Mixins.py(516): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/src/FWCore/ParameterSet/python/Modules.py(161): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/src/FWCore/ParameterSet/python/Config.py(1216): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/src/FWCore/ParameterSet/python/Config.py(1489): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

----- Begin Fatal Exception 23-Apr-2024 00:33:11 CEST-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_PAT_DQM.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoBTag/Combined/data/UParTAK4/PUPPI/V00/UParTAK4.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44805/39011/CMSSW_14_0_X_2024-04-22-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44805/39011/CMSSW_14_0_X_2024-04-22-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44805/39011/CMSSW_14_0_X_2024-04-22-1100/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/136.8311_RunJetHT2017FreMINIAOD


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/src/FWCore/ParameterSet/python/Types.py(881): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/src/FWCore/ParameterSet/python/Mixins.py(381): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/src/FWCore/ParameterSet/python/Mixins.py(516): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/src/FWCore/ParameterSet/python/Modules.py(161): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/src/FWCore/ParameterSet/python/Config.py(1216): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/src/FWCore/ParameterSet/python/Config.py(1489): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

----- Begin Fatal Exception 23-Apr-2024 00:33:11 CEST-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_PAT_DQM.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoBTag/Combined/data/UParTAK4/PUPPI/V00/UParTAK4.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44805/39011/CMSSW_14_0_X_2024-04-22-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44805/39011/CMSSW_14_0_X_2024-04-22-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44805/39011/CMSSW_14_0_X_2024-04-22-1100/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/136.7611_RunJetHT2016EreMINIAOD


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/src/FWCore/ParameterSet/python/Types.py(881): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/src/FWCore/ParameterSet/python/Mixins.py(381): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/src/FWCore/ParameterSet/python/Mixins.py(516): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/src/FWCore/ParameterSet/python/Modules.py(161): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/src/FWCore/ParameterSet/python/Config.py(1216): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/src/FWCore/ParameterSet/python/Config.py(1489): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------
Expand to see more relval errors ...

RelVals-INPUT

  • 4.64.6_MinimumBias2010A/step2_MinimumBias2010A.log
  • 136.72411136.72411_RunJetHT2016B_reminiaodUL/step2_RunJetHT2016B_reminiaodUL.log
  • 136.72412136.72412_RunJetHT2016B_reminiaodUL/step2_RunJetHT2016B_reminiaodUL.log
Expand to see more relval errors ...

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 3
  • DQMHistoTests: Total histograms compared: 39740
  • DQMHistoTests: Total failures: 191
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 39549
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
  • Checked 8 log files, 10 edm output root files, 3 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

+1
errors are clearly unrelated to this PR

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 23, 2024 •
edited
Loading

please test

The CMSSW_14_0_X_2024-04-22-2300 IB is hopefully in a better state.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f81a9/39015/summary.html
COMMIT: 198c126
CMSSW: CMSSW_14_0_X_2024-04-22-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44805/39015/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 33 differences found in the comparisons
  • DQMHistoTests: Total files compared: 3
  • DQMHistoTests: Total histograms compared: 39740
  • DQMHistoTests: Total failures: 1096
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 38644
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
  • Checked 8 log files, 10 edm output root files, 3 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+1

  • Identical to the PR in the master branch
  • This being technical, even if the master is not yet tested in IB, I can sign for alca/db: then the release managers will decide when to merge

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 222fc6a into cms-sw:CMSSW_14_0_X Apr 24, 2024
13 checks passed
@fwyzard fwyzard deleted the migrate_to_ALPAKA_ASSERT_ACC_140x branch June 13, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved backport-ok db-approved fully-signed heterogeneous-approved orp-approved reconstruction-approved tests-approved tracking trk urgent
Projects
None yet
Milestone
CMSSW_14_0_X
Development

Successfully merging this pull request may close these issues.
5 participants
@fwyzard @cmsbuild @mandrenguyen @perrotta @antoniovilela